Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4604 Bundle libmongocrypt 1.11.0 #876

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from a team as a code owner August 8, 2024 02:36
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clarifying question, otherwise LGTM!

}
],
"metadata": {
"timestamp": "2024-06-28T19:11:17.100829+00:00",
"timestamp": "2024-08-08T02:35:36.986098+00:00",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always going to be hardcoded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is auto-generated by Silk

@ShaneHarvey
Copy link
Member

Do we need to do any work in pymongocrypt for PYTHON-4392 before we release this?

@blink1073
Copy link
Member Author

Do we need to do any work in pymongocrypt for PYTHON-4392 before we release this?

The other way around, we need a release of pymongocrypt to support PYTHON-4392

@ShaneHarvey
Copy link
Member

Right, I get that but I'm wondering if we need to make any changes to the bindings besides upgrading to 1.11+.

@blink1073
Copy link
Member Author

Right, I get that but I'm wondering if we need to make any changes to the bindings besides upgrading to 1.11+.

I updated the bindings, and there were only docstring changes

@blink1073
Copy link
Member Author

@ShaneHarvey good to merge?

@blink1073 blink1073 merged commit d05dbf3 into mongodb:master Aug 12, 2024
60 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants